Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(when building) Module not found: Error: Cannot resolve module 'prop-types' in [app]/node_modules/react-c3js #23

Closed
CASandmann opened this issue May 18, 2017 · 0 comments
Closed

(when building) Module not found: Error: Cannot resolve module 'prop-types' in [app]/node_modules/react-c3js #23

CASandmann opened this issue May 18, 2017 · 0 comments
Assignees
@bcbcarl

Comments

@CASandmann
Copy link
Collaborator

For some reason, prop-types is listed as a dev dependency instead of a peer dependency or dependency. If it's not already in the consumer's stack, node is unable to find it and won't build.
@bcbcarl bcbcarl self-assigned this May 19, 2017
bcbcarl added a commit that referenced this issue May 19, 2017
@bcbcarl
Add prop-types as a peer dependency
7c38ba7 
Fixes #23.
@bcbcarl bcbcarl mentioned this issue May 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bcbcarl bcbcarl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bcbcarl @CASandmann