NinjaSlayer: NJコマンドでシークレットロールできないのを修正する #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
シークレットロールを示す先頭の「S」を考慮していなかった
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
=========================================
+ Coverage 86.07% 86.1% +0.03%
=========================================
Files 188 188
Lines 21826 21907 +81
=========================================
+ Hits 18786 18863 +77
- Misses 3040 3044 +4
Continue to review full report at Codecov.
|
ysakasin
added a commit
that referenced
this pull request
Aug 30, 2020
NinjaSlayer: NJコマンドでシークレットロールできないのを修正する
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NinjaSlayerのNJコマンドでシークレットロールできないのを修正しました。
changeTextで参照する正規表現において、シークレットロールを示す先頭のSを考慮していませんでした。