-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BBNTRPGを追加 #166
BBNTRPGを追加 #166
Conversation
Codecov Report
@@ Coverage Diff @@
## master #166 +/- ##
==========================================
+ Coverage 86.38% 86.40% +0.02%
==========================================
Files 204 205 +1
Lines 21267 21324 +57
==========================================
+ Hits 18371 18426 +55
- Misses 2896 2898 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
内容はこれで大丈夫だと思います。sequence.push
するところでメソッド呼び出しの括弧がない場合があるので、そこを括弧で囲むように統一すればなお良いです。
メソッド呼び出しの括弧を追加しました、マージしちゃいます |
* Add BBNTRPG * Refactor and add test BBNTRPG * Add BBNTRPG to CHANGELOG * Fix help message BBNTRPG * Fix description of fumble * sequence.push with a parenthesis
ルール
クリティカルとファンブルが同時発生したばあいにはクリティカルを優先する。