Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BBNTRPGを追加 #166

Merged
merged 6 commits into from
Apr 29, 2020
Merged

BBNTRPGを追加 #166

merged 6 commits into from
Apr 29, 2020

Conversation

ysakasin
Copy link
Member

@ysakasin ysakasin commented Apr 28, 2020

ルール

  • クリティカル
    • 出目「6」の数が振ったダイスの数の半分以上(切り上げ)のときにクリティカル
    • ただし、ダイス数1および2の時には、必要な出目「6」の数はそれぞれ1および2
    • クリティカルの時、「6」の数だけ追加ダイスを振る。追加ダイスでまた「6」がでたら、その分だけさらに追加ダイスを振る。「6」が出なくなるまで続ける
  • ファンブル
    • 出目「1」の数が振ったダイスの数の半分以上(切り上げ)のときにファンブル
    • ただし、ダイス数1および2の時には、必要な出目「1」の数はそれぞれ1および2
    • 判定は失敗となる

クリティカルとファンブルが同時発生したばあいにはクリティカルを優先する。

@ysakasin ysakasin added the new dicebot 新システムの対応 label Apr 28, 2020
@codecov-io
Copy link

codecov-io commented Apr 28, 2020

Codecov Report

Merging #166 into master will increase coverage by 0.02%.
The diff coverage is 96.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #166      +/-   ##
==========================================
+ Coverage   86.38%   86.40%   +0.02%     
==========================================
  Files         204      205       +1     
  Lines       21267    21324      +57     
==========================================
+ Hits        18371    18426      +55     
- Misses       2896     2898       +2     
Impacted Files Coverage Δ
src/diceBot/BBN.rb 96.49% <96.49%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47461ac...f3632f2. Read the comment docs.

Copy link
Member

@ochaochaocha3 ochaochaocha3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

内容はこれで大丈夫だと思います。sequence.push するところでメソッド呼び出しの括弧がない場合があるので、そこを括弧で囲むように統一すればなお良いです。

@ysakasin
Copy link
Member Author

メソッド呼び出しの括弧を追加しました、マージしちゃいます

@ysakasin ysakasin merged commit 9fef8ae into master Apr 29, 2020
@ysakasin ysakasin deleted the BBNTRPG branch April 29, 2020 08:24
ysakasin added a commit that referenced this pull request Aug 30, 2020
* Add BBNTRPG

* Refactor and add test BBNTRPG

* Add BBNTRPG to CHANGELOG

* Fix help message BBNTRPG

* Fix description of fumble

* sequence.push with a parenthesis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new dicebot 新システムの対応
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants