Vtm5th hunger limit #649
Merged
Vtm5th hunger limit #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #649 +/- ##
=======================================
Coverage 95.60% 95.60%
=======================================
Files 341 341
Lines 19584 19586 +2
Branches 5101 5103 +2
=======================================
+ Hits 18723 18725 +2
Misses 861 861 ☔ View full report in Codecov by Sentry. |
ysakasin
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
【背景】
#644 に記載した通り、V5の現行ルールではHungerダイスの上限は5ダイスであるにも関わらず、6以上のダイス数を指定できてしまう。
【対応】
ルールを把握している限り運用上で大きな問題にはならないが、入力ミスに気付かない等のケースを拾うため、5ダイス以上のHungerダイス指定にエラーメッセージを出すように修正、テストケースの追加を行う。