Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

『キルデスビジネス』大喜利スペシャル追加 #740

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

satsumawagashi
Copy link
Contributor

『まるごと一冊冒険企画局プラス』にて『キルデスビジネス』に追加されたルール「大喜利スペシャル」のすべての表はセッション中にするものなので、追加しました。

i18n/KillDeathBusiness/ja_jp.yml
lib/bcdice/game_system/KillDeathBusiness.rb
test/data/KillDeathBusiness.toml
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 95.94595% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.88%. Comparing base (5d33c39) to head (849fb1e).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
lib/bcdice/game_system/KillDeathBusiness.rb 95.94% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #740      +/-   ##
==========================================
+ Coverage   95.84%   95.88%   +0.03%     
==========================================
  Files         363      369       +6     
  Lines       21402    21691     +289     
  Branches     5617     5704      +87     
==========================================
+ Hits        20513    20798     +285     
- Misses        889      893       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ysakasin ysakasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

「お題決定表」ですが、追加で決定する分の出目が出力されないので、そちらも出力するようにしたいです。

さらに追加するとすれば、以下のように流れがわかるようになっていると良いかと思います。テキストの部分は公式の表記に適宜合わせてください。

お題決定表(6) > [〇〇を見て一言表]を見て一言。
〇〇を見て一言表(1) > ゲームマスターが最近撮ったor保存した写真
> ゲームマスターが最近撮ったor保存した写真を見て一言。

長いことレビューを返さずにいてすみません。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants