ワンダーオブワンダラーダイスbot作成 #748
Open
ワンダーオブワンダラーダイスbot作成 #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysakasin
requested changes
Jan 28, 2025
lib/bcdice/game_system/WoW.rb
Outdated
|
|
||
| # ダイスボットの使い方 | ||
| HELP_MESSAGE = <<~INFO_MESSAGE_TEXT | ||
| 行為判定 nWW12@s#f>=x |
There was a problem hiding this comment.
不等号の向きが実際とのコマンドとは逆に記載されているようなので、他の部分も含めて再確認の上、修正お願いします。
There was a problem hiding this comment.
ありがとうございます。こちら修正いたしました。どうぞよろしくお願いいたします！
ysakasin
requested changes
Jan 29, 2025
lib/bcdice/game_system/WoW.rb
Outdated
| def evaluate_expression(command) | ||
| # 数式の加算・減算部分をすべて評価 | ||
| while command.match(/(\d+[+-]\d+)/) | ||
| command.gsub!(/(\d+[+-]\d+)/) do |expression| |
lib/bcdice/game_system/WoW.rb
Outdated
| end | ||
|
|
||
| # 加算と減算の単純な式を計算するメソッド | ||
| def eval_simple_expression(expression) |
There was a problem hiding this comment.
BCDiceでは四則演算の計算用メソッド Arithmetic.eval を用意していますので、自前実装はせずにそちらを利用してください。
lib/bcdice/game_system/WoW.rb
Outdated
|
|
||
| def roll_wow(command) | ||
| # コマンド内の数式の評価を行う | ||
| command = process_command(command) |
There was a problem hiding this comment.
eval_game_system_specific_command に渡される時点で command はカッコ内の数式は全て計算された状態になっています。こちらの処理は不要かと思います。
|
こちら、対応いたしました！ありがとうございます |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
『シティ・ポップ・ファンタジーTRPG ワンダーオブワンダラー』のダイスbotを作成しました。
公式サイトは以下
https://ssproject.lsv.jp/wow/public/
作成が初めてなので至らない点があるかもしれませんが、どうぞよろしくお願いいたします。