This repository has been archived by the owner on Jul 27, 2024. It is now read-only.
Fix compilation errors in new vala #116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just tested and it builds😊 I see teo issues:
../src/Window.vala:94.32-94.56: warning: unhandled error `GLib.Error'
this.saved_state = AppSettings.get_default();
^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:114.17-114.37: warning: unhandled error `GLib.Error'
file.make_directory();
^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:123.17-123.37: warning: unhandled error `GLib.Error'
file.make_directory();
^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:1213.17-1213.46: warning: unhandled error `GLib.Error'
f.create(FileCreateFlags.NONE);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:1218.62-1218.69: warning: unhandled error `GLib.Error'
DataInputStream reader = new DataInputStream(f.read());
^^^^^^^^
../src/VGriveClient.vala:1220.30-1220.51: warning: unhandled error `GLib.IOError'
while ((line=reader.read_line(null)) != null) aux.set(line.split(";")[0], line.split(";")[1]);
^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:946.13-946.43: warning: unhandled error `GLib.Error'
parser.load_from_data (res, -1);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:980.17-980.47: warning: unhandled error `GLib.Error'
parser.load_from_data (res, -1);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:1400.17-1400.48: warning: unhandled error `GLib.Error'
f.move(dest, FileCopyFlags.NONE);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:1070.13-1070.43: warning: unhandled error `GLib.Error'
parser.load_from_data (res, -1);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:1228.35-1228.44: warning: unhandled error `GLib.Error'
if (f.query_exists()) f.delete();
^^^^^^^^^^
../src/VGriveClient.vala:1229.13-1229.42: warning: unhandled error `GLib.Error'
f.create(FileCreateFlags.NONE);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:1230.13-1230.48: warning: unhandled error `GLib.Error'
FileIOStream io = f.open_readwrite();
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:1232.13-1232.55: warning: unhandled error `GLib.IOError'
foreach (var entry in this.library.entries) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:707.13-707.43: warning: unhandled error `GLib.Error'
parser.load_from_data (res, -1);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:742.17-742.47: warning: unhandled error `GLib.Error'
parser.load_from_data (res, -1);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:1303.43-1303.63: warning: unhandled error `GLib.Error'
if (!file.query_exists()) file.make_directory();
^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:1307.43-1307.75: warning: unhandled error `GLib.Error'
if (!file.query_exists()) file.create(FileCreateFlags.NONE);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:1308.17-1308.55: warning: unhandled error `GLib.Error'
FileIOStream io = file.open_readwrite();
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:1310.17-1310.50: warning: unhandled error `GLib.IOError'
foreach (uint8 b in dfile.content) writer.put_byte(b);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:1388.26-1388.32: warning: `GLib.TimeVal' has been deprecated since 2.62
../src/VGriveClient.vala:1388.21-1388.22: warning: `GLib.TimeVal' has been deprecated since 2.62
../src/VGriveClient.vala:1390.13-1390.42: warning: `GLib.FileInfo.set_modification_time' has been deprecated since 2.62
../src/VGriveClient.vala:1387.13-1387.75: warning: unhandled error `GLib.Error'
FileInfo fileinfo = f.query_info ("*", FileQueryInfoFlags.NONE);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:1391.13-1391.73: warning: unhandled error `GLib.Error'
f.set_attributes_from_info(fileinfo, FileQueryInfoFlags.NONE);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:1414.35-1414.64: warning: `GLib.FileInfo.get_modification_time' has been deprecated since 2.62
../src/VGriveClient.vala:1414.21-1414.31: warning: `GLib.TimeVal' has been deprecated since 2.62
../src/VGriveClient.vala:1425.45-1425.66: warning: `GLib.TimeZone.new' has been deprecated since 2.68. Use TimeZone.identifier
../src/VGriveClient.vala:1435.46-1435.67: warning: `GLib.TimeZone.new' has been deprecated since 2.68. Use TimeZone.identifier
../src/VGriveClient.vala:1413.13-1413.79: warning: unhandled error `GLib.Error'
FileInfo fileinfo = lfile.query_info ("*", FileQueryInfoFlags.NONE);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:1038.13-1038.43: warning: unhandled error `GLib.Error'
parser.load_from_data (res, -1);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:920.13-920.53: warning: unhandled error `GLib.Error'
parser.load_from_data (res2.response, -1);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:1442.13-1442.85: warning: unhandled error `GLib.Error'
var enumerator = file.enumerate_children (FileAttribute.STANDARD_NAME, 0);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:1449.28-1449.50: warning: unhandled error `GLib.Error'
while ((info = enumerator.next_file ()) != null) {
^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:395.55-395.108: warning: unhandled error `GLib.Error'
if (this.is_regular_file (changed_file.query_info ("*", FileQueryInfoFlags.NONE))) this.change_detected = true;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:393.25-393.108: warning: unhandled error `GLib.Error'
FileMonitor monitor = dir_to_watch_file.monitor (FileMonitorFlags.WATCH_MOVES, null);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:1153.13-1153.43: warning: unhandled error `GLib.Error'
parser.load_from_data (res, -1);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:1164.13-1164.43: warning: unhandled error `GLib.Error'
parser.load_from_data (res, -1);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:1182.17-1182.47: warning: unhandled error `GLib.Error'
parser.load_from_data (res, -1);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:174.21-174.44: warning: unhandled error `GLib.Error'
maindir.make_directory();
^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:178.47-178.71: warning: unhandled error `GLib.Error'
if (!trashdir.query_exists()) trashdir.make_directory();
^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:183.31-183.82: warning: unhandled error `GLib.Error'
this.thread = new Thread<int>.try ("Sync thread", this.sync_files);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:454.13-454.43: warning: unhandled error `GLib.Error'
parser.load_from_data (res, -1);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:482.17-482.55: warning: unhandled error `GLib.Error'
parser.load_from_data (res.message, -1);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:503.33-503.53: warning: unhandled error `GLib.Error'
file.make_directory();
^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:516.25-516.57: warning: unhandled error `GLib.Error'
file.create(FileCreateFlags.NONE);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:517.25-517.63: warning: unhandled error `GLib.Error'
FileIOStream io = file.open_readwrite();
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:518.25-518.49: warning: unhandled error `GLib.Error'
io.seek (0, SeekType.END);
^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:520.25-520.54: warning: unhandled error `GLib.IOError'
writer.put_string(res.message);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:551.58-551.68: warning: unhandled error `GLib.Error'
DataInputStream reader = new DataInputStream(file.read());
^^^^^^^^^^^
../src/VGriveClient.vala:553.26-553.47: warning: unhandled error `GLib.IOError'
while ((line=reader.read_line(null)) != null) res = res.concat(line);
^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:556.13-556.43: warning: unhandled error `GLib.Error'
parser.load_from_data (res, -1);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:568.17-568.30: warning: unhandled error `GLib.Error'
file.delete ();
^^^^^^^^^^^^^^
../src/VGriveClient.vala:1336.13-1336.82: warning: unhandled error `GLib.Error'
var enumerator = f.enumerate_children (FileAttribute.STANDARD_NAME, 0);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:1337.28-1337.50: warning: unhandled error `GLib.Error'
while ((info = enumerator.next_file ()) != null) {
^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:1342.17-1342.29: warning: unhandled error `GLib.Error'
auxf.delete();
^^^^^^^^^^^^^
../src/views/SyncView.vala:91.13-91.55: warning: unhandled error `GLib.Error'
var saved_state = AppSettings.get_default();
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/views/SyncView.vala:157.13-157.55: warning: unhandled error `GLib.Error'
var saved_state = AppSettings.get_default();
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/views/LogInView.vala:91.13-91.55: warning: unhandled error `GLib.Error'
var saved_state = AppSettings.get_default();
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/views/LogInView.vala:124.17-124.95: warning: unhandled error `GLib.Error'
Gtk.show_uri_on_window (controler.window, controler.vgrive.get_auth_uri (), 10);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/views/LogInView.vala:134.17-134.59: warning: unhandled error `GLib.Error'
var saved_state = AppSettings.get_default();
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/views/LogInView.vala:153.13-153.55: warning: unhandled error `GLib.Error'
var saved_state = AppSettings.get_default();
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/views/ViewConf.vala:79.13-79.55: warning: unhandled error `GLib.Error'
var saved_state = AppSettings.get_default();
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/views/ViewConf.vala:264.25-264.82: warning: unhandled error `GLib.DBusError'
files.show_items ({ file.get_uri () }, Constants.APP_NAME);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/views/ViewConf.vala:146.13-146.55: warning: unhandled error `GLib.Error'
var saved_state = AppSettings.get_default();
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/views/ViewConf.vala:155.13-155.55: warning: unhandled error `GLib.Error'
var saved_state = AppSettings.get_default();
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/widgets/HeaderBar.vala:68.13-68.55: warning: unhandled error `GLib.Error'
var saved_state = AppSettings.get_default();
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/controllers/AppController.vala:48.13-48.55: warning: unhandled error `GLib.Error'
var saved_state = AppSettings.get_default();
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/Main.vala:58.9-58.51: warning: unhandled error `GLib.Error'
var saved_state = AppSettings.get_default();
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/views/LogInView.vala:142.21-142.23: warning: Local variable `res' declared but never used
var res = controler.vgrive.request_and_set_credentials(grive_code.get_text());
^^^
../src/views/SyncView.vala:81.9-81.35: warning: Method `App.Views.SyncView.build_title' never used
private Gtk.Box build_title(AppController controler) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/VGriveClient.vala:1347.20-1347.22: warning: Local variable `aux' declared but never used
string aux = Soup.URI.encode(param, null);
^^^
../src/Window.vala:88.15-88.29: warning: unreachable catch clause detected
} catch (Error e) {
^^^^^^^^^^^^^^^
+ /usr/bin/meson test -C x86_64-redhat-linux-gnu --num-processes 48 --print-errorlogs
ninja: Entering directory `/home/tkloczko/rpmbuild/BUILD/VGrive-1.6.1/x86_64-redhat-linux-gnu'
ninja: no work to do.
1/3 Validate desktop file OK 0.03s
2/3 Validate schema file OK 0.01s
3/3 Validate appstream file FAIL 1.41s exit status 1
>>> MALLOC_PERTURB_=174 /usr/bin/appstream-util validate data/com.github.bcedu.vgrive.appdata.xml
――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― ✀ ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
stdout:
data/com.github.bcedu.vgrive.appdata.xml: FAILED:
• style-invalid : <image> has vertical padding [https://raw.githubusercontent.com/bcedu/VGrive/master/data/imgs/init.png]
• style-invalid : <image> has horizontal padding [https://raw.githubusercontent.com/bcedu/VGrive/master/data/imgs/init.png]
• style-invalid : <image> has vertical padding [https://raw.githubusercontent.com/bcedu/VGrive/master/data/imgs/login.png]
• style-invalid : <image> has horizontal padding [https://raw.githubusercontent.com/bcedu/VGrive/master/data/imgs/login.png]
• style-invalid : <image> has vertical padding [https://raw.githubusercontent.com/bcedu/VGrive/master/data/imgs/login2.png]
• style-invalid : <image> has horizontal padding [https://raw.githubusercontent.com/bcedu/VGrive/master/data/imgs/login2.png]
• style-invalid : <image> has vertical padding [https://raw.githubusercontent.com/bcedu/VGrive/master/data/imgs/sync.png]
• style-invalid : <image> has horizontal padding [https://raw.githubusercontent.com/bcedu/VGrive/master/data/imgs/sync.png]
• style-invalid : <image> has vertical padding [https://raw.githubusercontent.com/bcedu/VGrive/master/data/imgs/advanced.png]
• style-invalid : <image> has horizontal padding [https://raw.githubusercontent.com/bcedu/VGrive/master/data/imgs/advanced.png]
stderr:
Validation of files failed
――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
Summary of Failures:
3/3 Validate appstream file FAIL 1.41s exit status 1But as I wrote at leeast it builds now 👍 😊 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with Vala 0.50.3 in Manjaro.