Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have taken a stab at trying to fix #899. This will add a new subproject to produce a BOM which includes all the other subprojects and their versions. The published BOM can be declared in
<dependencyManagement>
in apom.xml
like this:And this will ensure all BouncyCastle artifacts included in the dependency graph to be managed to the same version, even though you may not explicitly depend on them in your project, and your dependencies may themselves depend on different BouncyCastle artifacts and versions. Example:
Resulting published POM
(Omitted the various XML declarations for brevity)
Questions
This is the first time I have done anything remotely involved with Gradle, so there may be better way to achieve this.
bom/build.gradle
, I am listing all subproject to be included, verbatim. Should this be resolved on its own somehow?description
. Should this be omitted in the new bom subproject as well?bc-bom-$vmrange
be something else, to align with existing naming conventions? E.g.bcbom
(without a dash)? I think I would prefer e.g.bouncycastle-bom-jdk18on
, but that may be deviating too far from existing naming.