fix: release 3.0.0 doc and script issue (#86)

* fix: release 3.0.0 doc and script issue * fix: move set of vault environment before validation
bcgov-nr · Jul 4, 2023 · 5be5724 · 5be5724
1 parent 2ae517b
commit 5be5724
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 13 deletions.
diff --git a/README.md b/README.md
@@ -59,7 +59,7 @@ $ ./scripts/mongo-setup.sh
 
 ```bash
 # Start up local vault
-$ podman run -p 8200:8200 --cap-add=IPC_LOCK -e 'VAULT_DEV_ROOT_TOKEN_ID=myroot' -d --name=broker-vault vault
+$ podman run -p 8200:8200 --cap-add=IPC_LOCK -e 'VAULT_DEV_ROOT_TOKEN_ID=myroot' -d --name=broker-vault hashicorp/vault
 ```
 
 Once started, you must run the vault setup script to bootstrap it.

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "nr-broker",
-  "version": "3.0.0",
+  "version": "3.0.1",
   "description": "",
   "author": "",
   "private": true,

diff --git a/scripts/db/mongo-setup.js b/scripts/db/mongo-setup.js
@@ -38,6 +38,7 @@ db.environment.insertOne({
   aliases: [],
   vertex: result.insertedId,
 });
+result = db.vertex.insertOne({ collection: 'environment', name: 'tools' });
 db.environment.insertOne({
   name: 'tools',
   short: 'tools',

diff --git a/src/intention/intention.service.ts b/src/intention/intention.service.ts
@@ -107,6 +107,17 @@ export class IntentionService {
     }
 
     for (const action of intentionDto.actions) {
+      const envDto = envMap[action.service.environment];
+      if (
+        action.vaultEnvironment === undefined &&
+        envDto &&
+        (envDto.name === 'production' ||
+          envDto.name === 'test' ||
+          envDto.name === 'development' ||
+          envDto.name === 'tools')
+      ) {
+        action.vaultEnvironment = envDto.name;
+      }
       const validationResult = this.actionService.validate(
         intentionDto,
         action,
@@ -126,17 +137,6 @@ export class IntentionService {
         trace_id: action.trace.hash,
         outcome: validationResult === null ? 'success' : 'failure',
       };
-      const envDto = envMap[action.service.environment];
-      if (
-        action.vaultEnvironment === undefined &&
-        envDto &&
-        (envDto.name === 'production' ||
-          envDto.name === 'test' ||
-          envDto.name === 'development' ||
-          envDto.name === 'tools')
-      ) {
-        action.vaultEnvironment = envDto.name;
-      }
     }
     const isSuccessfulOpen = actionFailures.length === 0;
     this.auditService.recordIntentionOpen(req, intentionDto, isSuccessfulOpen);