Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX][NRPTI-1233] updated bcmi collection migration to properly find all relevant permits #1244

Merged

Conversation

acatchpole
Copy link
Contributor

The original migration was only looking for permits with _schemaName == PermitBCMI. It turns out that many of the mine permits actually have _schemaName == Permit. The migration has been updated to capture both these sets of permits when updating the document collection.

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [NRPTI-###]
  • Documentation is updated to reflect change

Description

This PR includes the following proposed change(s):

  • Fixed BCMICollection update migration by including missing permits from the available records to check.

@acatchpole acatchpole requested a review from sggerard June 24, 2024 16:52
@acatchpole acatchpole marked this pull request as ready for review June 24, 2024 16:52
@acatchpole acatchpole self-assigned this Jun 24, 2024
Copy link

sonarcloud bot commented Jun 24, 2024

@acatchpole acatchpole merged commit 02a49b2 into master Jun 24, 2024
4 checks passed
@acatchpole acatchpole deleted the 1233-updating-migration-to-properly-capture-all-permits branch June 24, 2024 16:57
@acatchpole acatchpole restored the 1233-updating-migration-to-properly-capture-all-permits branch June 24, 2024 17:28
sggerard pushed a commit that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants