Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NRPT-711: Update redacted record subset on mongoose save and update #836

Merged
merged 9 commits into from
Apr 28, 2021
Merged

NRPT-711: Update redacted record subset on mongoose save and update #836

merged 9 commits into from
Apr 28, 2021

Conversation

MaxWardle
Copy link
Contributor

mtCarto
mtCarto approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@mtCarto mtCarto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, confirmed that the redacted subset is properly updated on record changes 👍

@MaxWardle MaxWardle requested a review from marklise April 27, 2021 23:12
@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@MaxWardle MaxWardle merged commit b56fa09 into bcgov:master Apr 28, 2021
@MaxWardle MaxWardle deleted the NRPT-711 branch May 3, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BcGovNeal BcGovNeal BcGovNeal approved these changes

@mtCarto mtCarto mtCarto approved these changes

@marklise marklise marklise approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MaxWardle @marklise @mtCarto @BcGovNeal