[PIMS-248] BUG: zoom wrong location upon marker click

[dbarkowsky]

🎯 Summary

PIMS-248:

Issue

Addressing a bug where clicking a marker causes the map to centre and zoom to the wrong location. Usually it would centre on the default centre of the province on the first click, then on the previous marker on subsequent clicks.

Cause

Issue was caused by a useEffect in Map.tsx that set the map's view before the information was updated.

Fix

Removed the useEffect. Added command for centre and zoom to the call when the data is fetched upon marker click in PointClusterer.tsx.

Testing

Click some markers on the map. You should no longer be zoomed to unexpected locations.

🔰 Checklist

• I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.

• I have performed a self-review of my code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation where required.
• I have tested my changes to the best of my ability.
• My changes generate no new warnings.

[dbarkowsky]

Fix is in place, but waiting to hear back from Lindsay on how she would like the centre and zoom behaviour to work before making my final changes and publishing for review.

[codeclimate]

Code Climate has analyzed commit 117ca71 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	1

The test coverage on the diff in this pull request is 80.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 54.8%.

View more on Code Climate.

[dbarkowsky]

Lindsay's suggestion was to remove the automatic centring and zooming.
Here is the code to restore this in case it is needed. It should be placed in PointClusterer.tsx, within the fetchProperty callback, inside the .then portion of getParcel and getBuilding.
Replace parcel with building where needed.
There is an option to only centre if desired, but it is commented out. If you only want to centre, uncomment that line, and remove the other two inside the if statement.

if (parcel.latitude !== '' && parcel.longitude !== '') {
    // mapInstance.setView({ lat: parcel.latitude, lng: parcel.longitude }); // just centre
    mapInstance.setView({ lat: parcel.latitude, lng: parcel.longitude }, MAX_ZOOM); // centre and zoom
    dispatch(setMapViewZoom(MAX_ZOOM)); // determines how markers are clustered; call this if you zoom
}

[TaylorFries]

This update works well for me! Builds fine and no apparent issues.
We may want to test on a Windows machine to ensure that updates are consistent across OSs.