Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-336 Surplus Properties Popup Styling #1884

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

dbarkowsky
Copy link
Collaborator

@dbarkowsky dbarkowsky commented Nov 6, 2023

🎯 Summary

PIMS-336

Converted the styled-components in this file to scss. Adjusted styling for a more uniform look.

Had to scope a class from UsersFilterBar.scss. It would apply to the styles on the Surplus Properties popup if a user navigated to the Users page and back.

image

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link

codeclimate bot commented Nov 6, 2023

Code Climate has analyzed commit 740c942 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 75.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 55.0%.

View more on Code Climate.

@dbarkowsky dbarkowsky marked this pull request as ready for review November 6, 2023 23:23
@TaylorFries
Copy link
Collaborator

TaylorFries commented Nov 9, 2023

noting that it might be nice to leave a space to the left of this dropdown for map controls - can add a follow up ticket for this work .

UPDATE: created PIMS-377 to do this work.

Copy link
Collaborator

@TaylorFries TaylorFries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

styling looks great! Approved!
Hurray to removing more in-line and styled-components

@dbarkowsky dbarkowsky merged commit 567b29c into dev Nov 9, 2023
2 checks passed
@dbarkowsky dbarkowsky deleted the PIMS-336-Surplus-Properties-Style-Fixes branch November 9, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants