Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-83 Remove text-mask-addons #1920

Merged
merged 7 commits into from
Nov 23, 2023
Merged

Conversation

dbarkowsky
Copy link
Collaborator

🎯 Summary

PIMS-83: Remove text-mask-addons

Original goal was to make our own text mask that would handle currency. I tried a few different attempts, but there's something about how it stores the current value that wasn't being persisted each run.

Ended up finding the code from the original dependency. With a little conversion for TypeScript, it seems to work the same as it did when we used the whole dependency.

Testing

Find a currency field, like on the Valuation tab of a property. Try entering different values and see if the results are what you would expect.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link

🚀 Deployment Information

The APP Image has been built with the tag: 1920. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link

codeclimate bot commented Nov 22, 2023

Code Climate has analyzed commit 71f752d and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 97.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 55.7%.

View more on Code Climate.

@dbarkowsky
Copy link
Collaborator Author

dbarkowsky commented Nov 22, 2023

Working on getting a test file in. Done. Used their test file from the original package as a base.

@dbarkowsky dbarkowsky marked this pull request as ready for review November 22, 2023 21:53
@dbarkowsky dbarkowsky changed the title PIMS-83 Create Own Currency Mask PIMS-83 Remove text-mask-addons Nov 22, 2023
Copy link
Collaborator

@TaylorFries TaylorFries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested changes and numbers seem to update as expected.

  • only note is that it doesn't show decimal points, but the dependency also missed this. Maybe we could add a ticket to try and fix the decimals in the future?

@dbarkowsky
Copy link
Collaborator Author

dbarkowsky commented Nov 23, 2023

Tested changes and numbers seem to update as expected.

  • only note is that it doesn't show decimal points, but the dependency also missed this. Maybe we could add a ticket to try and fix the decimals in the future?

I think this is a conflict with the default settings for the masks. I'll ask what they prefer and either disallow the decimal by default or increase decimalLimit to 2.

Update: Did both. Shouldn't allow decimals now, but if someone passes configs to change that, it will at least restrict to 2 decimal placed by default.

@dbarkowsky dbarkowsky merged commit 289ceb3 into main Nov 23, 2023
4 checks passed
@dbarkowsky dbarkowsky deleted the PIMS-83-Create-Own-Currency-Mask branch November 23, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants