-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIMS-83 Remove text-mask-addons #1920
Conversation
🚀 Deployment Information The APP Image has been built with the tag: |
Code Climate has analyzed commit 71f752d and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 97.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 55.7%. View more on Code Climate. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested changes and numbers seem to update as expected.
- only note is that it doesn't show decimal points, but the dependency also missed this. Maybe we could add a ticket to try and fix the decimals in the future?
I think this is a conflict with the default settings for the masks. I'll ask what they prefer and either disallow the decimal by default or increase decimalLimit to 2. Update: Did both. Shouldn't allow decimals now, but if someone passes configs to change that, it will at least restrict to 2 decimal placed by default. |
🎯 Summary
PIMS-83: Remove text-mask-addons
Original goal was to make our own text mask that would handle currency. I tried a few different attempts, but there's something about how it stores the current value that wasn't being persisted each run.
Ended up finding the code from the original dependency. With a little conversion for TypeScript, it seems to work the same as it did when we used the whole dependency.
Testing
Find a currency field, like on the Valuation tab of a property. Try entering different values and see if the results are what you would expect.
🔰 Checklist