PIMS-511: Opening a property from the View Inventory page doesn't take you to location #1961
+41
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LawrenceLau2020
requested review from
Sharala-Perumal,
dbarkowsky and
TaylorFries
as code owners
|
🚀 Deployment Information The APP Image has been built with the tag: |
LawrenceLau2020
commented
Dec 4, 2023
| @@ -266,7 +274,7 @@ export const InventoryLayer: React.FC<InventoryLayerProps> = ({ | |||
| // Fit to municipality bounds | |||
| map.fitBounds((GeoJSON.geometryToLayer(municipality) as any)._bounds, { maxZoom: 11 }); | |||
| } | |||
| } else if (results.length > 0) { | |||
| } else if (results.length > 0 && isMapView && isSidebarOpen === 'false') { | |||
There was a problem hiding this comment.
I'm not sure if there's a more elegant way of doing this, such as preventing the search from getting called...
There was a problem hiding this comment.
I notice there's a side effect with this when you select a property from View Inventory then close the side menu.
It closes the side menu but then resets the view to be province-wide.
There was a problem hiding this comment.
I see, is this also the same issue in production?
dbarkowsky
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Summary
PIMS-511: - Opening a property from the View Inventory page doesn't take you to location
Because the "search" function is called when viewing a property from the view inventory page, I added a way to check if the user is on the "map" page or viewing the property details page. This should be tested thoroughly from all areas of the PIMS application.
There is still an issue with the marker not being centered.
🔰 Checklist