-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIMS-421 Routes - Properties #2001
Conversation
Code Climate has analyzed commit 9932be3 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 93.7%. View more on Code Climate. |
While testing the routes I get the following response:
The following log is printed in the express-api:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All property routes return expected results. tested a few other routes too and they all act as expected.
🎯 Summary
PIMS-421
These were all search routes. There was one,
properties/search/names
that I don't think is actually used currently (at least I can't find an example), so I omitted it.Additionally, I changed the routes with
wfs
togeo
. These are the ones that retrieve the lists of properties for map marker population right now.wfs
isn't a very descriptive name, so I'm hoping thatgeo
will make it a little more obvious what it's used for.Some other considerations when we start implementing controllers...
It feels like the filter routes could just be part of the GET routes, but with some query parameters. There doesn't appear to be anything confidential transmitted, so the use of a POST might not be necessary.
Changes
🔰 Checklist