Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-421 Routes - Properties #2001

Merged
merged 12 commits into from
Jan 6, 2024
Merged

PIMS-421 Routes - Properties #2001

merged 12 commits into from
Jan 6, 2024

Conversation

dbarkowsky
Copy link
Collaborator

🎯 Summary

PIMS-421

These were all search routes. There was one, properties/search/names that I don't think is actually used currently (at least I can't find an example), so I omitted it.

Additionally, I changed the routes with wfs to geo. These are the ones that retrieve the lists of properties for map marker population right now. wfs isn't a very descriptive name, so I'm hoping that geo will make it a little more obvious what it's used for.

Some other considerations when we start implementing controllers...
It feels like the filter routes could just be part of the GET routes, but with some query parameters. There doesn't appear to be anything confidential transmitted, so the use of a POST might not be necessary.

Changes

  • Added stub controllers for properties
  • Added routes that expose these controllers
  • Added stub integration and unit tests.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link

codeclimate bot commented Jan 2, 2024

Code Climate has analyzed commit 9932be3 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 93.7%.

View more on Code Climate.

@TaylorFries
Copy link
Collaborator

While testing the routes I get the following response:

"error": "User must have all of the following roles: [Admin]"

The following log is printed in the express-api:

{"level":"http","message":{"method":"GET","responseTimeMs":194.385,"route":"/api/v2/properties/search","status":403},"timestamp":"2024-01-03 11:14:06.934 AM"}

Copy link
Collaborator

@TaylorFries TaylorFries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All property routes return expected results. tested a few other routes too and they all act as expected.

@dbarkowsky dbarkowsky merged commit 8c61533 into main Jan 6, 2024
3 checks passed
@dbarkowsky dbarkowsky deleted the PIMS-421-Routes-Properties branch January 6, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants