Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-619 React App Linting #2002

Merged
merged 2 commits into from
Jan 2, 2024
Merged

PIMS-619 React App Linting #2002

merged 2 commits into from
Jan 2, 2024

Conversation

dbarkowsky
Copy link
Collaborator

🎯 Summary

PIMS-619

Adds ESLint and Prettier using similar configurations to our existing frontend.
Fixed some existing linting issues.

Same commands as the express-api to run linting.

  • npm run lint to check everything
  • npm run lint:fix to fix the easy stuff automatically
  • npm run check to check only the prettier rules
  • npm run format to fix the prettier rule violations

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link
Collaborator

@TaylorFries TaylorFries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scripts lint, lint:fix, check, and format all work as expected.

@dbarkowsky dbarkowsky merged commit b1a2869 into main Jan 2, 2024
1 check passed
@dbarkowsky dbarkowsky deleted the PIMS-619-Frontend-Linting branch January 2, 2024 23:30
TaylorFries pushed a commit that referenced this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants