Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-1236 Updated prettier to 3.2.4 (express-api) #2177

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

dbarkowsky
Copy link
Collaborator

@dbarkowsky dbarkowsky commented Feb 8, 2024

🎯 Summary

PIMS-1236

tsconfig.json needed extra comma after update to comply with prettier, but that broke jest.
Ended up ignoring tsconfig.json in .prettierignore

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@dbarkowsky dbarkowsky force-pushed the PIMS-1236-Update-prettier-express-api branch from f627dfa to d082690 Compare February 8, 2024 23:32
Copy link

codeclimate bot commented Feb 8, 2024

Code Climate has analyzed commit 845b15a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 91.2%.

View more on Code Climate.

Copy link
Collaborator

@TaylorFries TaylorFries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applied changes locally both prettier scripts work as expected.

@dbarkowsky dbarkowsky merged commit b0448ce into main Feb 12, 2024
3 checks passed
@dbarkowsky dbarkowsky deleted the PIMS-1236-Update-prettier-express-api branch February 12, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants