Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC Assessment Popup #2236

Merged
merged 16 commits into from
Mar 18, 2024
Merged

BC Assessment Popup #2236

merged 16 commits into from
Mar 18, 2024

Conversation

GrahamS-Quartech
Copy link
Contributor

@GrahamS-Quartech GrahamS-Quartech commented Mar 9, 2024

🎯 Summary

PIMS-###:

  • Adds a button and dialog to the map parcel popup in similar style to LTSA info for the private BC Assessment API.
  • Uses the somewhat naive approach of checking the current browser URL to determine which version of the API to call. Not possible to set this using Openshift.
  • Note that calls to the API will bounce unless you are authorized on their end.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link

github-actions bot commented Mar 9, 2024

🚀 Deployment Information

The APP Image has been built with the tag: 2236. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link

codeclimate bot commented Mar 9, 2024

Code Climate has analyzed commit 3c9efe6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 42.3% (50% is the threshold).

This pull request will bring the total coverage in the repository to 55.8%.

View more on Code Climate.

Copy link
Collaborator

@dbarkowsky dbarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing in OpenShift. Working well.
Ideally we find a workaround for local development at some point that isn't modifying the hosts file.

Comment on lines +38 to +63
// GEN_GROSS_LAND_VALUE: {
// label: 'Gross Land Value:',
// display: (data: any) => (
// <>{data.GEN_GROSS_LAND_VALUE ? `$${data.GEN_GROSS_LAND_VALUE}` : `N/A`}</>
// ),
// },
// GEN_GROSS_IMPROVEMENT_VALUE: {
// label: 'Gross Improvement Value:',
// display: (data: any) => (
// <>{data.GEN_GROSS_IMPROVEMENT_VALUE ? `$${data.GEN_GROSS_IMPROVEMENT_VALUE}` : `N/A`}</>
// ),
// },
// GEN_NET_LAND_VALUE: {
// label: 'Net Land Value:',
// display: (data: any) => <>{data.GEN_NET_LAND_VALUE ? `$${data.GEN_NET_LAND_VALUE}` : `N/A`}</>,
// },
// GEN_NET_IMPROVEMENT_VALUE: {
// label: 'Net Improvement Value:',
// display: (data: any) => (
// <>{data.GEN_NET_IMPROVEMENT_VALUE ? `$${data.GEN_NET_IMPROVEMENT_VALUE}` : `N/A`}</>
// ),
// },
// FOLIO_ID: {
// label: 'Folio ID:',
// display: (data: any) => <>{data.FOLIO_ID ? `${data.FOLIO_ID}` : `N/A`}</>,
// },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with leaving this here. Easy to uncomment if we want it back.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I felt there was a non-zero chance we might move the information around so I figured I would leave it there for now.

@GrahamS-Quartech GrahamS-Quartech merged commit d99927a into main Mar 18, 2024
5 checks passed
@GrahamS-Quartech GrahamS-Quartech deleted the bcassessment-lookup branch March 18, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants