-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BC Assessment Popup #2236
BC Assessment Popup #2236
Conversation
…he right information in the popup
🚀 Deployment Information The APP Image has been built with the tag: |
Code Climate has analyzed commit 3c9efe6 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 42.3% (50% is the threshold). This pull request will bring the total coverage in the repository to 55.8%. View more on Code Climate. |
…g for the new values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing in OpenShift. Working well.
Ideally we find a workaround for local development at some point that isn't modifying the hosts file.
// GEN_GROSS_LAND_VALUE: { | ||
// label: 'Gross Land Value:', | ||
// display: (data: any) => ( | ||
// <>{data.GEN_GROSS_LAND_VALUE ? `$${data.GEN_GROSS_LAND_VALUE}` : `N/A`}</> | ||
// ), | ||
// }, | ||
// GEN_GROSS_IMPROVEMENT_VALUE: { | ||
// label: 'Gross Improvement Value:', | ||
// display: (data: any) => ( | ||
// <>{data.GEN_GROSS_IMPROVEMENT_VALUE ? `$${data.GEN_GROSS_IMPROVEMENT_VALUE}` : `N/A`}</> | ||
// ), | ||
// }, | ||
// GEN_NET_LAND_VALUE: { | ||
// label: 'Net Land Value:', | ||
// display: (data: any) => <>{data.GEN_NET_LAND_VALUE ? `$${data.GEN_NET_LAND_VALUE}` : `N/A`}</>, | ||
// }, | ||
// GEN_NET_IMPROVEMENT_VALUE: { | ||
// label: 'Net Improvement Value:', | ||
// display: (data: any) => ( | ||
// <>{data.GEN_NET_IMPROVEMENT_VALUE ? `$${data.GEN_NET_IMPROVEMENT_VALUE}` : `N/A`}</> | ||
// ), | ||
// }, | ||
// FOLIO_ID: { | ||
// label: 'Folio ID:', | ||
// display: (data: any) => <>{data.FOLIO_ID ? `${data.FOLIO_ID}` : `N/A`}</>, | ||
// }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with leaving this here. Easy to uncomment if we want it back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I felt there was a non-zero chance we might move the information around so I figured I would leave it there for now.
🎯 Summary
PIMS-###:
🔰 Checklist