Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-1431 Evaluation/Fiscal Key Migration #2248

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

dbarkowsky
Copy link
Collaborator

🎯 Summary

PIMS-1431

Evaluation and Fiscal keys are populated from 1 to 3, but original PIMS started at 0.

Need to adjust the keys to allow for easier ETL.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link

🚀 Deployment Information

The Express API Image has been built with the tag: 2248. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link

codeclimate bot commented Mar 13, 2024

Code Climate has analyzed commit dad5e13 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 93.8%.

View more on Code Climate.

Copy link
Collaborator

@LawrenceLau2020 LawrenceLau2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Ran the "local" ETL task with no issues.

@dbarkowsky dbarkowsky merged commit e2363df into main Mar 13, 2024
5 checks passed
@dbarkowsky dbarkowsky deleted the PIMS-1431-Evaluation-Fiscal-Keys branch March 13, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants