PIMS-1472 Controller Error Wrapper

[dbarkowsky]

🎯 Summary

PIMS-1472

This wrapper, when placed around a controller, ensures that any thrown errors are caught and passed to the generic error handler. No more reason to wrap the internal implementation of individual controllers in try/catch blocks unless you want to send a specific status/code. Consider this a fallback option when we fail to handle errors uniquely.

Changes

• Added catchError function (thanks @GrahamS-Quartech for the initial code)
• Added this function to all existing controllers in routes files
• Updated controllers to reflect this change (mostly removing try/catch where it only returns default code/message)
• Updated tests to match

🔰 Checklist

• I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.

• I have performed a self-review of my code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation where required.
• I have tested my changes to the best of my ability.
• My changes generate no new warnings.

[github-actions]

🚀 Deployment Information

The Express API Image has been built with the tag: 2266. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

[codeclimate]

Code Climate has analyzed commit c069138 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 96.9% (50% is the threshold).

This pull request will bring the total coverage in the repository to 94.9%.

View more on Code Climate.