Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-1483: Lookup and Administraive Areas Hooks #2270

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

GrahamS-Quartech
Copy link
Contributor

🎯 Summary

Added hooks for obtaining various lookup values needed for the add property form. Also implemented them into the form itself.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

…operty form. Also implemented them into the form itself.
Copy link

🚀 Deployment Information

The React APP Image has been built with the tag: 2270. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link
Collaborator

@dbarkowsky dbarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Hooks appear to be working.

Some thoughts for another ticket:

  • Would be nice if date fields had a popup for the picking
  • Should format currency fields to comma delimit and prevent more than 2 decimals
  • Classifications should be mandatory
    • Same with Administrative Area, Lat/Lng,
  • Postal Code not mandatory
  • PID not mandatory for Parcel, because could just have PIN. Needs at least one.
  • I don't think we need the section on owning a parcel anymore. If they don't own it, we don't add it. This means it could come out of the entity as well.

Will save these for next standup.

@GrahamS-Quartech
Copy link
Contributor Author

All valid thoughts, a lot of these things are just assumptions I made from the design or things other people seemed to think were required, but yeah let's just go over these in stand up later and see what people think 👍

@GrahamS-Quartech GrahamS-Quartech merged commit a2e5e8b into main Mar 22, 2024
5 checks passed
@GrahamS-Quartech GrahamS-Quartech deleted the PIMS-1483-LookupHooks branch March 22, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants