Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-1490 Last name fix #2275

Merged
merged 2 commits into from
Mar 25, 2024
Merged

PIMS-1490 Last name fix #2275

merged 2 commits into from
Mar 25, 2024

Conversation

dbarkowsky
Copy link
Collaborator

@dbarkowsky dbarkowsky commented Mar 25, 2024

🎯 Summary

PIMS-1490

Changes

  • Update usernameUpdater tool to add check if the last name field is empty and get the last name from the first name field if available

Tested locally and then in DEV. Please see DEV to check if the changes are acceptable.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link
Collaborator

@LawrenceLau2020 LawrenceLau2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, much more consistent user data now.

@dbarkowsky dbarkowsky merged commit 61d1965 into main Mar 25, 2024
1 check passed
@dbarkowsky dbarkowsky deleted the PIMS-1490-Last-Names branch March 25, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants