PIMS-1404 Agency Details

[dbarkowsky]

🎯 Summary

PIMS-1404

Changes

• Add Agencies Details page, which includes:
  • Editing agency details and notification settings
  • Deleting agency (only if there are no FK constraints. We need a more user-friendly outcome for these)
• useAgencies API hooks

Testing

• Navigate to the Administration > Agencies page. /admin/agencies
• Select an agency and try editing, etc.

🔰 Checklist

• I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.

• I have performed a self-review of my code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation where required.
• I have tested my changes to the best of my ability.
• My changes generate no new warnings.

[github-actions]

🚀 Deployment Information

The Express API Image has been built with the tag: 2283. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

[github-actions]

🚀 Deployment Information

The React APP Image has been built with the tag: 2283. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

[GrahamS-Quartech]

Couple things I noticed:

• The email input works nicely with the enter key but I was expecting it to do something similar when I pressed comma or semi-colon... Instead, it will just eat the input but do nothing with it when you hit submit. I think forcing the use of enter key could be fine if it's indicated somehow, but I think better would be allowing enter, comma, or semi-colon.
• You can set the agency's parent to itself, which I imagine isn't valid? But doesn't seem to cause an error necessarily.

[codeclimate]

Code Climate has analyzed commit 2f49def and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Duplication	2

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.0%.

View more on Code Climate.

[dbarkowsky]

Couple things I noticed:

• The email input works nicely with the enter key but I was expecting it to do something similar when I pressed comma or semi-colon... Instead, it will just eat the input but do nothing with it when you hit submit. I think forcing the use of enter key could be fine if it's indicated somehow, but I think better would be allowing enter, comma, or semi-colon.
• You can set the agency's parent to itself, which I imagine isn't valid? But doesn't seem to cause an error necessarily.

• Email chips should now delimit via comma or semicolon as well. The secret was not specifying a key for the TextField and then also having the value attached to inputValue on the Autocomplete, not the TextField.
• An agency's parent can no longer be set to itself or one of its current children. Marked those options as disabled in the autocomplete.
• Still need to validate email input, but I'm thinking that is part of the future ticket for zod validation.

[GrahamS-Quartech]

* Still need to validate email input, but I'm thinking that is part of the future ticket for zod validation.

Yeah this was the only thing I was gonna comment on, otherwise all works nicely now. Approving.