PIMS-1518: Add Administrative Area

[GrahamS-Quartech]

🎯 Summary

PIMS-1518

Pretty simple add form as there's not many fields for this data type. Should return you to the table view on submission.

Note that because the sequence for the administrative_area table's PK is not advanced during seeding, you may get failed POST requests after a couple adds. To fix this, simply advance the sequence manually. You can do this with SELECT setval('administrative_area_id_seq', (SELECT MAX(id) FROM administrative_area));. Another ticket will follow to address this with a migration.

🔰 Checklist

• I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.

• I have performed a self-review of my code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation where required.
• I have tested my changes to the best of my ability.
• My changes generate no new warnings.

[github-actions]

🚀 Deployment Information

The React APP Image has been built with the tag: 2298. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

[codeclimate]

Code Climate has analyzed commit 5287f63 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 90.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 94.6%.

View more on Code Climate.

[github-actions]

🚀 Deployment Information

The Express API Image has been built with the tag: 2298. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

[LawrenceLau2020]

Looks good, I was able to add a few new admin areas ("1000 Mile house" and "1001 Mile house", the first one was inserted with id =1, so had to use that setval to enable the correct sequencing.

The only thing I noticed, was that the sorting was a bit strange as I was expecting the new ones to show at the top of the list, but I had to manually sort by Name ascending to get it to display.

Perhaps the default sort order isn't by name ascending?

[dbarkowsky]

Seems good. I added some default sorting and pagination.
I wonder if we need users to specify the sort order. It doesn't look like it has ever been used for this table.