-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIMS-1545: AgenciesController auth checks #2320
Conversation
🚀 Deployment Information The Express API Image has been built with the tag: |
Code Climate has analyzed commit df19522 and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 94.8%. View more on Code Climate. |
🚀 Deployment Information The React APP Image has been built with the tag: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well for me.
In the future, let's see if we could extract this check into a single function. Then it could be used in many places without duplicate code.
This is acceptable if we only need this for agencies pages right now but this is really something that should be implemented in the AuthRouteGuard or some similar wrapper component. |
🎯 Summary
PIMS-1545: - AgenciesController auth checks
Added a frontend authorization check to the agency management and the agency details pages and changed the route to a protected route.
You can test using a role of "General User" which shouldn't be able to access the Agency admin page: http://localhost:3000/admin/agencies and should be redirected to the homepage.
Only admin and auditor roles should be able to access it.
May need to confirm that auditors should be able to access these pages.
🔰 Checklist