Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-1582 Options Filter Fix #2329

Merged
merged 2 commits into from
Apr 17, 2024
Merged

PIMS-1582 Options Filter Fix #2329

merged 2 commits into from
Apr 17, 2024

Conversation

dbarkowsky
Copy link
Collaborator

🎯 Summary

PIMS-1582

Changes

  • Autocomplete field now filters on the label again. Not sure when this originally broke.
  • Noticed that child agencies weren't sorted. Changed sorting code to make this work.

Testing

  • Play with the autocomplete fields (especially grouped agencies)

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link

🚀 Deployment Information

The React APP Image has been built with the tag: 2329. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link
Collaborator

@LawrenceLau2020 LawrenceLau2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dbarkowsky dbarkowsky merged commit fdd889c into main Apr 17, 2024
7 checks passed
@dbarkowsky dbarkowsky deleted the PIMS-1582-Options-Filter branch April 17, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants