Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-1622: Handle task array #2348

Merged
merged 17 commits into from
May 1, 2024
Merged

PIMS-1622: Handle task array #2348

merged 17 commits into from
May 1, 2024

Conversation

GrahamS-Quartech
Copy link
Contributor

🎯 Summary

PIMS-1622

  • Changed the ProjectWithTasks type to accept a stripped down ProjectTask entity (only really need to know task_id and whether it was marked completed)
  • Added a handler for the included project tasks that fires in the transaction block of the add / update services for projects.
  • Added a notification handler that fires on updates, but the functionality is just a stub (PIMS-1623)

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link

🚀 Deployment Information

The Express API Image has been built with the tag: 2348. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link

🚀 Deployment Information

The React APP Image has been built with the tag: 2348. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

@dbarkowsky
Copy link
Collaborator

Sharala also has a portion in her PR for Project Details that joins the ProjectTask table, so we'll have the tasks with their IDs available.

Copy link

codeclimate bot commented Apr 29, 2024

Code Climate has analyzed commit 37ab25d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.4%.

View more on Code Climate.

@GrahamS-Quartech GrahamS-Quartech merged commit 39912b4 into main May 1, 2024
5 checks passed
@GrahamS-Quartech GrahamS-Quartech deleted the PIMS-1622-TaskArray branch May 1, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants