Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-1676: Skeleton Loading #2373

Merged
merged 2 commits into from
May 8, 2024
Merged

PIMS-1676: Skeleton Loading #2373

merged 2 commits into from
May 8, 2024

Conversation

GrahamS-Quartech
Copy link
Contributor

🎯 Summary

PIMS-1676

  • Added skeleton component and loading logic to DataCard, since this is definitely the component that needs it the most.
  • Added loading prop wired to the relevant data loader hook in each of the main data cards.

Testing this is kind of annoying since it relies on the async calls being delayed, but you should be able to see it working pretty easily moving between tables/detail pages.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

…rops passed everywhere the DataCard is currently used.
Copy link

github-actions bot commented May 8, 2024

🚀 Deployment Information

The React APP Image has been built with the tag: 2373. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link
Collaborator

@dbarkowsky dbarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GrahamS-Quartech GrahamS-Quartech merged commit c664af7 into main May 8, 2024
5 checks passed
@GrahamS-Quartech GrahamS-Quartech deleted the PIMS-1676-SkeletonLoad branch May 8, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants