Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-1675 Replacing MarkerCluster with Supercluster #2375

Merged
merged 17 commits into from
May 10, 2024

Conversation

dbarkowsky
Copy link
Collaborator

@dbarkowsky dbarkowsky commented May 9, 2024

🎯 Summary

PIMS-1675

Changes

  • Swap out previous cluster package with a simpler but faster one
  • Rework spiderfier and point clusterer logic from old PIMS to work in new PIMS.
  • Fix errors with MapPropertyDetails
  • Adjust endpoint for geojson data

Testing

  • Navigate to /dev endpoint
  • Use map, opening and closing clusters, etc.

This approach didn't come with all the bells and whistles as the last package, but I think it scales better. I have about 25000 properties on my map, and there's no slow down, compared with the last package which had major loading times.

In the future, it would be good to tweak some of the behaviours of the clustering. Maybe we could find a way to implement smooth movement as well.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link

github-actions bot commented May 9, 2024

🚀 Deployment Information

The Express API Image has been built with the tag: 2375. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link

codeclimate bot commented May 9, 2024

Code Climate has analyzed commit 0a71cb5 and detected 6 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 6

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.3%.

View more on Code Climate.

@dbarkowsky dbarkowsky merged commit e1c8fad into main May 10, 2024
9 checks passed
@dbarkowsky dbarkowsky deleted the PIMS-1675-Supercluster branch May 10, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants