-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIMS-1675 Replacing MarkerCluster with Supercluster #2375
Conversation
🚀 Deployment Information The Express API Image has been built with the tag: |
Code Climate has analyzed commit 0a71cb5 and detected 6 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.3%. View more on Code Climate. |
🎯 Summary
PIMS-1675
Changes
Testing
This approach didn't come with all the bells and whistles as the last package, but I think it scales better. I have about 25000 properties on my map, and there's no slow down, compared with the last package which had major loading times.
In the future, it would be good to tweak some of the behaviours of the clustering. Maybe we could find a way to implement smooth movement as well.
🔰 Checklist