Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-1596 Remove Sort Order Option #2412

Merged
merged 6 commits into from
May 29, 2024
Merged

Conversation

dbarkowsky
Copy link
Collaborator

@dbarkowsky dbarkowsky commented May 28, 2024

🎯 Summary

PIMS-1596

Changes

  • Removes option for the user to specify the sort order field on admin areas
  • Adds default values for any SortOrder and IsDisabled columns so they don't have to be manually specified in the API if missing.

Testing

  • Try editing, adding, viewing admin areas

This change includes a migration. The date column was never dropped from when we changed the evaluation entity, so it got included in this migration as well. -Removed

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link

🚀 Deployment Information

The Express API Image has been built with the tag: 2412. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link

codeclimate bot commented May 28, 2024

Code Climate has analyzed commit 31211aa and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 94.5%.

View more on Code Climate.

Copy link

🚀 Deployment Information

The React APP Image has been built with the tag: 2412. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link
Contributor

@GrahamS-Quartech GrahamS-Quartech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well for me now that the migration is fixed

@dbarkowsky dbarkowsky merged commit e1997c0 into main May 29, 2024
11 checks passed
@dbarkowsky dbarkowsky deleted the PIMS-1596-Remove-Sort-Order-Option branch May 29, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants