Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LTSA Tests #2419

Merged
merged 3 commits into from
May 29, 2024
Merged

Update LTSA Tests #2419

merged 3 commits into from
May 29, 2024

Conversation

dbarkowsky
Copy link
Collaborator

🎯 Summary

Trying to solve the issue with some of these tests working intermittently. Mocked the implementation of the ltsaService so it's not calling the LTSA on every test run. Updated the ILtsaOrder interface in the backend to add missing parameters from the response.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link

🚀 Deployment Information

The Express API Image has been built with the tag: 2419. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link

codeclimate bot commented May 29, 2024

Code Climate has analyzed commit 9fddab2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 94.3%.

View more on Code Climate.

@GrahamS-Quartech GrahamS-Quartech merged commit d784c37 into main May 29, 2024
7 checks passed
@GrahamS-Quartech GrahamS-Quartech deleted the LTSA-Testing-Update branch May 29, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants