-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIMS-1802: Bulk Upload Page #2515
Conversation
…fault fetch to avoid wrapping file as JSON.
…e included in the initial response from POSTing to import. Rearranged the way that results are displayed.
…ownload button to the results
🚀 Deployment Information The Express API Image has been built with the tag: |
🚀 Deployment Information The React APP Image has been built with the tag: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
… PIMS-1802-BulkUploadPage
Code Climate has analyzed commit fde428b and detected 4 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 36.3% (50% is the threshold). This pull request will bring the total coverage in the repository to 93.7%. View more on Code Climate. |
I think this might just be the test CSV having the wrong header (should be LandArea and not Land (space) Area). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working well for me. Knocking it out of the park. ⚾
A few comments to discuss then let's get it in.
…out transaction bits. Limited frontend bulk upload access to just ADMIN.
Just noting here that Steven helped us decide that PID will remain mandatory for now. |
🎯 Summary
PIMS-1802
🔰 Checklist