Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-1802: Bulk Upload Page #2515

Merged
merged 13 commits into from
Jul 10, 2024
Merged

PIMS-1802: Bulk Upload Page #2515

merged 13 commits into from
Jul 10, 2024

Conversation

GrahamS-Quartech
Copy link
Contributor

🎯 Summary

PIMS-1802

  • Adds a bulk upload page with similar elements to the PIMS v1 version.
  • Can be navigated to from the admin menu in the header. As such, it is a protected route.
  • You should be able to click the dashed line area or drag and drop into it to attach a file.
  • Once a file is attached, you can hit upload and the file will begin processing.
  • The loading bar will progress based on the contents of the API call made every X seconds using the interval inside the useEffect.
  • You can download the results of your most recent upload as an XLSX file or just view in the MUI data grid component.
  • There are also some small changes to the backend. Mostly just adding some missed fields into the import service and modifying the way that the import_result row is first created so that it can be returned in the initial call the to the import endpoint.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link

github-actions bot commented Jul 9, 2024

🚀 Deployment Information

The Express API Image has been built with the tag: 2515. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link

github-actions bot commented Jul 9, 2024

🚀 Deployment Information

The React APP Image has been built with the tag: 2515. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link
Collaborator

@dbarkowsky dbarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the UI here.

  • Land Area doesn't seem to be populated, even when the row has a value. Makes the details page look like this:
    image
  • PID/PIN may have to be joint optional fields. Right now PID is mandatory, but there are parcels that will only have a PIN.

Copy link

codeclimate bot commented Jul 9, 2024

Code Climate has analyzed commit fde428b and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 4

The test coverage on the diff in this pull request is 36.3% (50% is the threshold).

This pull request will bring the total coverage in the repository to 93.7%.

View more on Code Climate.

@GrahamS-Quartech
Copy link
Contributor Author

Like the UI here.

* Land Area doesn't seem to be populated, even when the row has a value. Makes the details page look like this:

I think this might just be the test CSV having the wrong header (should be LandArea and not Land (space) Area).

Copy link
Collaborator

@dbarkowsky dbarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well for me. Knocking it out of the park. ⚾
A few comments to discuss then let's get it in.

express-api/src/services/properties/propertiesServices.ts Outdated Show resolved Hide resolved
express-api/src/services/properties/propertiesServices.ts Outdated Show resolved Hide resolved
react-app/src/App.tsx Outdated Show resolved Hide resolved
react-app/src/pages/BulkUpload.tsx Show resolved Hide resolved
…out transaction bits. Limited frontend bulk upload access to just ADMIN.
@GrahamS-Quartech
Copy link
Contributor Author

PID/PIN may have to be joint optional fields. Right now PID is mandatory, but there are parcels that will only have a PIN.

Just noting here that Steven helped us decide that PID will remain mandatory for now.

@GrahamS-Quartech GrahamS-Quartech merged commit 7e67fc5 into main Jul 10, 2024
13 checks passed
@GrahamS-Quartech GrahamS-Quartech deleted the PIMS-1802-BulkUploadPage branch July 10, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants