-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIMS-1756: Template formatting and hyperlink fixes #2554
PIMS-1756: Template formatting and hyperlink fixes #2554
Conversation
…t gets a non-spreadsheet file.
…rsion of templates, including missing project numbers, using wront identifier for determining property type, nullish coalescing operators, and a few others. Uri for the current environment's uri will not be included in relevant <a> tags. Slight change to gathering project and relations for the generating notifications function.
🚀 Deployment Information The Express API Image has been built with the tag: |
Code Climate has analyzed commit 5534a2a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 92.5%. View more on Code Climate. |
What's the best way to test this? Just send yourself emails, I suppose? |
Yeah, I would just choose a project with a few properties that have assessment values on them and try changing them into statuses that will prompt notifications. You can also add a new test project to ensure the new project notification works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
notifications are sent for creation of projects and appropriate statuses changes (to: submitted, submitted exemption, approved for erp, denied, cancelled, in erp)
no issues detected.
🎯 Summary
PIMS-1756:
...And probably a couple other things too.
Please give it a decent read over and let me know if I missed something.
🔰 Checklist