Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-1889: Timeout the loading spinner when credentials are missing #2559

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

GrahamS-Quartech
Copy link
Contributor

@GrahamS-Quartech GrahamS-Quartech commented Jul 19, 2024

🎯 Summary

PIMS-1889

Added an automatic timeout to the loading spinner so that you will be automatically prompted to log in again if it seems like your credentials never got loaded. Also added a little message box so that users know to just wait a sec if they are seeing the loading spinner. A bit hacky, but the user experience is not too bad I think.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

… automatically prompted to log in again if it seems like your credentials never got loaded
Copy link

🚀 Deployment Information

The React APP Image has been built with the tag: 2559. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link
Collaborator

@TaylorFries TaylorFries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, no hanging circle loader. Message looks good. No issues found.

@GrahamS-Quartech GrahamS-Quartech merged commit db86145 into main Jul 22, 2024
9 checks passed
@GrahamS-Quartech GrahamS-Quartech deleted the PIMS-1899-TimeoutLoadingSpinner branch July 22, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants