Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-1883 Code Commenting Spree #2588

Merged
merged 7 commits into from
Jul 31, 2024
Merged

PIMS-1883 Code Commenting Spree #2588

merged 7 commits into from
Jul 31, 2024

Conversation

dbarkowsky
Copy link
Collaborator

@dbarkowsky dbarkowsky commented Jul 30, 2024

🎯 Summary

PIMS-1883

Changes

  • Mostly adding a lot of code comments where missing
    • Focused on the API. Looking at the React components, it didn't seem like comments made as much sense there
  • Removed a few instances of code that wasn't up to date and also not used anywhere

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link

codeclimate bot commented Jul 30, 2024

Code Climate has analyzed commit 5ed488c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 92.5%.

View more on Code Climate.

Copy link
Collaborator

@TaylorFries TaylorFries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

documentation looks great!

@dbarkowsky dbarkowsky merged commit e12007b into main Jul 31, 2024
13 checks passed
@dbarkowsky dbarkowsky deleted the PIMS-1883-Code-Commenting branch July 31, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants