Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-1773: Auditor Scoping #2593

Merged
merged 23 commits into from
Aug 2, 2024
Merged

Conversation

TaylorFries
Copy link
Collaborator

🎯 Summary

PIMS-1773:

as specified in the comment chain on the linked ticket - auditors should be able to see all properties, scoped projects, and not notifications or interested agencies on a project.
Please refer to ticket comments for clarification.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link

🚀 Deployment Information

The React APP Image has been built with the tag: 2593. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

…pt that is actually executed when a worker thread is forked so that it can be tested reliably
Copy link

codeclimate bot commented Aug 1, 2024

Code Climate has analyzed commit 4d6fc93 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 90.9% (50% is the threshold).

This pull request will bring the total coverage in the repository to 93.9%.

View more on Code Climate.

Copy link
Collaborator

@dbarkowsky dbarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Auditor role is now more restricted.

@TaylorFries TaylorFries merged commit 79f75fd into main Aug 2, 2024
13 checks passed
@TaylorFries TaylorFries deleted the PIMS-1773-more-non-admin-hidden-areas branch August 2, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants