Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-1934 Enhanced Referral Dates #2609

Merged
merged 5 commits into from
Aug 9, 2024

Conversation

dbarkowsky
Copy link
Collaborator

🎯 Summary

PIMS-1934

Changes

  • Added DateFields to the ProjectNotificationsTable component to show sendOn properties.

Testing

  • Open an existing project
    • If the project doesn't have those types of notifications, it will not populate the field.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link

github-actions bot commented Aug 7, 2024

🚀 Deployment Information

The React APP Image has been built with the tag: 2609. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

@GrahamS-Quartech
Copy link
Contributor

Much better with the lookup changes there. My only other thought is possibly hiding these values text boxes when the notifications have not been sent out.

@dbarkowsky
Copy link
Collaborator Author

Much better with the lookup changes there. My only other thought is possibly hiding these values text boxes when the notifications have not been sent out.

Made this change. If any of the notifications aren't found, it doesn't render the group of date fields.

Copy link
Contributor

@GrahamS-Quartech GrahamS-Quartech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest change is good. Just gonna merge this cause I want some of these changes in another PR.

@GrahamS-Quartech GrahamS-Quartech merged commit 3eafe2e into main Aug 9, 2024
9 checks passed
@GrahamS-Quartech GrahamS-Quartech deleted the PIMS-1934-Notification-Dates branch August 9, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants