-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIMS-1985: Agency selection on add property #2629
PIMS-1985: Agency selection on add property #2629
Conversation
…encies if admin. Updated property general form to use this in an autocomplete component. Field is marked required.
🚀 Deployment Information The React APP Image has been built with the tag: |
… Improved the getUserAgencies hook to leverage the groupedAgencies hook for improved display in the dropdown.
Code Climate has analyzed commit 4a6be49 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 66.6% (50% is the threshold). This pull request will bring the total coverage in the repository to 93.7%. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made myself a General user with agency of "School District 100" whose parent is Education and Child Care (ECC). I seem to be only able to see my own agency and none of the other children agencies of ECC.
This is what we want, right? Users of parent agencies can see the children, but child agencies cannot. |
Yeah this is intentional from what I understood. |
Ok, sounds good, my bad.....I misunderstood the requirements. |
…cgov/PIMS into PIMS-1985-AgencySelectionOnAddProperty
…ub.com/bcgov/PIMS into PIMS-1985-AgencySelectionOnAddProperty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working for me now as expected.
Thanks for adding the indented select options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well, was able to see only my agency when my user's agency is a child agency, and tested as a user belonging to a parent agency, was able to change an existing property to other child agencies.
Just adding for documentation purposes that I checked in with Josh and Steven and this is indeed the expected behavior. So I will now merge. |
🎯 Summary
PIMS-1985
🔰 Checklist