PIMS-1984: Fiscal year only takes year values. #2632
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Summary
PIMS-1984
Just adding a numeric prop to the text field could have solved this bug but it seemed like it may be better to just constrain this input a lot more in general. After all, there's really only two options that may be valid, max. So with that in mind I've tried to make this a single select style input instead. I also made it so that you can't add more rows once you've added current year and previous year, since past that point nothing else is valid.
🔰 Checklist