Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-1984: Fiscal year only takes year values. #2632

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

GrahamS-Quartech
Copy link
Contributor

🎯 Summary

PIMS-1984

Just adding a numeric prop to the text field could have solved this bug but it seemed like it may be better to just constrain this input a lot more in general. After all, there's really only two options that may be valid, max. So with that in mind I've tried to make this a single select style input instead. I also made it so that you can't add more rows once you've added current year and previous year, since past that point nothing else is valid.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

…led, helper text, validation rules. FiscalYear now uses this to display year options. Also can't add more rows if the current years are already present.
Copy link

🚀 Deployment Information

The React APP Image has been built with the tag: 2632. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link
Collaborator

@dbarkowsky dbarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working well for me.
The maxRows is sometimes 1. I think that will be ok, but noting that we could up it if needed.

@GrahamS-Quartech GrahamS-Quartech merged commit b4f2d6b into main Aug 16, 2024
9 checks passed
@GrahamS-Quartech GrahamS-Quartech deleted the PIMS-1984-FiscalYearDontAcceptLetters branch August 16, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants