Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-1999 Terms and Conditions Wording #2647

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Conversation

dbarkowsky
Copy link
Collaborator

@dbarkowsky dbarkowsky commented Aug 28, 2024

🎯 Summary

PIMS-1999

Changes

  • Changed the wording on the signup statement to read:
    By signing up, you confirm that you have read the Disclaimer and Privacy Policy.
  • Made sure they open in new links so users don't lose what they've already filled out in the form

Testing

  • See the Access Request page
    • You may have to temporarily alter your username in the database to see this, or change the code that determines when it pops up.
  • Test that the links work

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link

🚀 Deployment Information

The React APP Image has been built with the tag: 2647. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link
Collaborator

@LawrenceLau2020 LawrenceLau2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, links open in new windows, no issues detected.

@dbarkowsky dbarkowsky merged commit 617405b into main Sep 4, 2024
8 checks passed
@dbarkowsky dbarkowsky deleted the PIMS-1999-Terms-and-Services branch September 4, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants