-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIMS-1859 PID Formatter Fix #2656
Conversation
🚀 Deployment Information The React APP Image has been built with the tag: |
The changes work well, only thing to note is that when using PID filter on the map if you enter more than 9 numbers it errors out. maybe add a catch for that scenario? |
Good catch. I think there's some other behaviour that was unexpected as well... |
@TaylorFries Made a change that should prioritize the first 9 digits. Does this seem more intuitive? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works very well and I think covers all tests i could think of trying.
🎯 Summary
PIMS-1859
Changes
Testing
Please try entering PID in many ways, some expected and unexpected.
Does it behave like you would expect?
🔰 Checklist