Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-1859 PID Formatter Fix #2656

Merged
merged 3 commits into from
Sep 9, 2024
Merged

PIMS-1859 PID Formatter Fix #2656

merged 3 commits into from
Sep 9, 2024

Conversation

dbarkowsky
Copy link
Collaborator

@dbarkowsky dbarkowsky commented Sep 4, 2024

🎯 Summary

PIMS-1859

Changes

  • Move some formatting to the onBlur prop
  • Make sure any passed onBlur is also called
  • Adjust onChange prop to accept full numeric PID or hyphenated PID

Testing

Please try entering PID in many ways, some expected and unexpected.
Does it behave like you would expect?

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link

github-actions bot commented Sep 4, 2024

🚀 Deployment Information

The React APP Image has been built with the tag: 2656. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

@TaylorFries
Copy link
Collaborator

The changes work well, only thing to note is that when using PID filter on the map if you enter more than 9 numbers it errors out. maybe add a catch for that scenario?

@dbarkowsky
Copy link
Collaborator Author

The changes work well, only thing to note is that when using PID filter on the map if you enter more than 9 numbers it errors out. maybe add a catch for that scenario?

Good catch. I think there's some other behaviour that was unexpected as well...

@dbarkowsky
Copy link
Collaborator Author

@TaylorFries Made a change that should prioritize the first 9 digits. Does this seem more intuitive?

Copy link
Collaborator

@TaylorFries TaylorFries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works very well and I think covers all tests i could think of trying.

@dbarkowsky dbarkowsky merged commit b846a88 into main Sep 9, 2024
9 checks passed
@dbarkowsky dbarkowsky deleted the PIMS-1859-PID-Formatter-Fix branch September 9, 2024 20:02
dbarkowsky added a commit that referenced this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants