Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ipad support #1255

Merged
merged 5 commits into from
Jul 17, 2023
Merged

feat: ipad support #1255

merged 5 commits into from
Jul 17, 2023

Conversation

jleach
Copy link
Member

@jleach jleach commented Jul 12, 2023

Add support for iPads and use the new single icon feature of Xcode 14+ to simplify icon management for iPhone and iPad.

Fixes #1241

@jleach jleach self-assigned this Jul 12, 2023
@jleach jleach marked this pull request as ready for review July 14, 2023 15:54
@jleach jleach enabled auto-merge (squash) July 14, 2023 15:59
bryce-mcmath
bryce-mcmath previously approved these changes Jul 14, 2023
@jleach jleach dismissed bryce-mcmath’s stale review July 14, 2023 18:37

The merge-base changed after approval.

bryce-mcmath
bryce-mcmath previously approved these changes Jul 14, 2023
@jleach jleach dismissed bryce-mcmath’s stale review July 14, 2023 18:43

The merge-base changed after approval.

@jleach jleach disabled auto-merge July 14, 2023 18:57
@jleach jleach requested a review from bryce-mcmath July 14, 2023 18:57
bryce-mcmath
bryce-mcmath previously approved these changes Jul 14, 2023
@jleach jleach dismissed bryce-mcmath’s stale review July 14, 2023 18:58

The merge-base changed after approval.

@bryce-mcmath bryce-mcmath self-requested a review July 14, 2023 19:58
bryce-mcmath
bryce-mcmath previously approved these changes Jul 14, 2023
@jleach jleach dismissed bryce-mcmath’s stale review July 14, 2023 19:59

The merge-base changed after approval.

@bryce-mcmath bryce-mcmath self-requested a review July 14, 2023 19:59
bryce-mcmath
bryce-mcmath previously approved these changes Jul 14, 2023
@jleach jleach dismissed bryce-mcmath’s stale review July 14, 2023 20:06

The merge-base changed after approval.

wadeking98
wadeking98 previously approved these changes Jul 14, 2023
bryce-mcmath
bryce-mcmath previously approved these changes Jul 14, 2023
@jleach jleach dismissed stale reviews from bryce-mcmath and wadeking98 July 14, 2023 20:12

The merge-base changed after approval.

bryce-mcmath
bryce-mcmath previously approved these changes Jul 16, 2023
@jleach jleach dismissed bryce-mcmath’s stale review July 16, 2023 02:07

The merge-base changed after approval.

@jleach jleach requested a review from bryce-mcmath July 17, 2023 16:10
bryce-mcmath
bryce-mcmath previously approved these changes Jul 17, 2023
@jleach jleach dismissed bryce-mcmath’s stale review July 17, 2023 16:11

The merge-base changed after approval.

wadeking98
wadeking98 previously approved these changes Jul 17, 2023
@jleach jleach dismissed wadeking98’s stale review July 17, 2023 16:19

The merge-base changed after approval.

Signed-off-by: Jason C. Leach <jason.leach@fullboar.ca>
Signed-off-by: Jason C. Leach <jason.leach@fullboar.ca>
Signed-off-by: Jason C. Leach <jason.leach@fullboar.ca>
Signed-off-by: Jason C. Leach <jason.leach@fullboar.ca>
Signed-off-by: Jason C. Leach <jason.leach@fullboar.ca>
@sonarcloud
Copy link

sonarcloud bot commented Jul 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jleach jleach merged commit 044f8c9 into main Jul 17, 2023
@jleach jleach deleted the feat/ipad-support branch July 17, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable iPad support
3 participants