Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated DEVELOPER.md documentation #1592

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Updated DEVELOPER.md documentation #1592

merged 3 commits into from
Dec 13, 2023

Conversation

esune
Copy link
Member

@esune esune commented Nov 8, 2023

Updated documentation in DEVELOPER.md:

  • Added required dependencies (Yarn, JDK, Gradle) and tips for installing cocoapods
  • Revisited steps to add custom ledgers to the project

Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
@cvarjao cvarjao requested a review from jleach November 16, 2023 23:25
DEVELOPER.md Outdated
Following along, you should end up using Android SDK Platform 30 with Android 11 (API Level 30) for Android development and/or iOS 11 for iOS development.
Following along, you should end up using Android SDK Platform 33 with Android 13 (API Level 33) for Android development and/or iOS 11 for iOS development.

**Notes:** you may need to install `cocoapods` using `brew` rather than Ruby's package manager on MacOS 14.x if you encounter installation errors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend using bundle install ... as we are using in the GHA workflow. Installing at system level might break existing dev environment

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good tip, I wish I had known when I went through the setup process - I'll try it out and update accordingly if it works as expected.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I refreshed the instructions: the installation of cocoapods now seems to succeed by following the instructions in the react native/Cocoapods getting started, however I had to add explicit version dependencies on Ruby and Bundler to resolve this. Additionally, it looks like the version of Ruby being used (2.7.8) is past its end-of-life: maybe something to track in an issue? Only installing pods as in the GHA does not work so the pre-requisites still apply.

Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
Copy link

sonarcloud bot commented Nov 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@esune esune requested a review from cvarjao November 22, 2023 21:49
@bryce-mcmath bryce-mcmath self-requested a review December 13, 2023 23:21
@bryce-mcmath bryce-mcmath merged commit 536721b into bcgov:main Dec 13, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants