Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update bifold packages, push notif and attestation, run lint #1675

Merged
merged 5 commits into from
Dec 14, 2023

Conversation

bryce-mcmath
Copy link
Contributor

The updated Bifold packages include some changes to the core module for various fixes and features and a change to the attestation native module for iOS. In-app guides will now be GA, and I've made a change so that the Push Notification modal doesn't appear at the same time as the in-app guide modal. I also ran the linter which picked up quite a few things.

…lint

Signed-off-by: Bryce McMath <bryce.j.mcmath@gmail.com>
Signed-off-by: Bryce McMath <bryce.j.mcmath@gmail.com>
@bryce-mcmath bryce-mcmath marked this pull request as ready for review December 13, 2023 21:06
Signed-off-by: Bryce McMath <bryce.j.mcmath@gmail.com>
Signed-off-by: Bryce McMath <bryce.j.mcmath@gmail.com>
Signed-off-by: Bryce McMath <bryce.j.mcmath@gmail.com>
Copy link

sonarcloud bot commented Dec 13, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bryce-mcmath bryce-mcmath merged commit 32f12a0 into main Dec 14, 2023
8 checks passed
@bryce-mcmath bryce-mcmath deleted the chore/update-bifold-packages branch December 14, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants