Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct spaces urls #1783

Merged
merged 1 commit into from
Feb 9, 2024
Merged

fix: correct spaces urls #1783

merged 1 commit into from
Feb 9, 2024

Conversation

jleach
Copy link
Member

@jleach jleach commented Feb 9, 2024

This pulls in a fix to an AFJ package where URLs with spaces in them are properly decoded when fetched. This can occurs because some schemas have spaces in the names which fails when fetching the associated tails file. This is an example of the error:

  "message": "Error while retrieving tails file from URL https://tails-test.vonx.io/TeT8SJGHruVL9up3Erp4o:4:TeT8SJGHruVL9up3Erp4o:3:CL:224665:Selling It Right:CL_ACCUM:6d6f660b-7b89-4812-87fe-5d286e7dd63c",

I checked the difference between 0.4.0 and 0.4.2 of the @aries-framework/react-native package and this is the only change:

vc-wallet-mobile git:(main) ✗ diff app/node_modules/@aries-framework/react-native/build/ReactNativeFileSystem.js /tmp/ReactNativeFileSystem.js
79a80
>         const fromUrl = this.encodeUriIfRequired(url);
81c82
<             fromUrl: url,
---
>             fromUrl,
95a97,101
>     encodeUriIfRequired(uri) {
>         // Some characters in the URL might be invalid for
>         // the native os to handle. Only encode if necessary.
>         return uri === decodeURI(uri) ? encodeURI(uri) : uri;
>     }vc-wallet-mobile git:(main) ✗

Signed-off-by: Jason C. Leach <jason.leach@fullboar.ca>
Copy link

sonarcloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jleach jleach self-assigned this Feb 9, 2024
@jleach jleach enabled auto-merge (squash) February 9, 2024 22:52
@jleach jleach merged commit dd99864 into main Feb 9, 2024
6 of 8 checks passed
@jleach jleach deleted the fix/space-in-url branch February 9, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants