fix: prevent duplicate connections from being scanned #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bryce McMath <bryce.j.mcmath@gmail.com>
|
jleach
approved these changes
Mar 6, 2024
| @@ -77,7 +77,7 @@ const configuration: ConfigurationContext = { | |||
| disableOnboardingSkip: true, | |||
| useCustomNotifications: useNotifications, | |||
| useAttestation: useAttestation, | |||
| enableUseMultUseInvitation: true, | |||
| enableUseMultUseInvitation: false, | |||
There was a problem hiding this comment.
Did I just recently see a PR go through that changed this value?
There was a problem hiding this comment.
yes, that change needs to be reverted as it's part of the cause of the duplicate connection issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents the camera from freezing when scanning an invalid QR code and also prevents duplicate connections from being made when scanning a valid QR twice