Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added Push notificaiton screen #1858

Merged
merged 6 commits into from
Mar 14, 2024
Merged

Conversation

wadeking98
Copy link
Contributor

Added push notification screen in onboarding and settings menu.
Depends on: openwallet-foundation/bifold-wallet#1111

Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
@jleach jleach changed the title Feat: added Push notificaiton screen feat: added Push notificaiton screen Mar 13, 2024
Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
app/src/helpers/PushNotificationsHelper.ts Outdated Show resolved Hide resolved
app/src/index.ts Outdated Show resolved Hide resolved
@jleach
Copy link
Member

jleach commented Mar 13, 2024

@wadeking98 If push notifications are going GA do we need to remove the on-off capability from Developer settings?

Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
… feat-push-notif-screen

Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
@wadeking98 wadeking98 requested a review from jleach March 13, 2024 19:32
Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
Copy link
Contributor

@bryce-mcmath bryce-mcmath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just cocoapods version change, other than that looks good

app/ios/Podfile.lock Outdated Show resolved Hide resolved
Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
Copy link

sonarcloud bot commented Mar 14, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@wadeking98 wadeking98 merged commit a9ceabe into main Mar 14, 2024
6 checks passed
@wadeking98 wadeking98 deleted the feat-push-notif-screen branch March 14, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants