Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attestation workflow 2 #1890

Merged
merged 3 commits into from
Mar 28, 2024
Merged

fix: attestation workflow 2 #1890

merged 3 commits into from
Mar 28, 2024

Conversation

jleach
Copy link
Member

@jleach jleach commented Mar 28, 2024

Update the person credential to use an alternate workflow where it waits for all attestation steps to complete before proceeding with BSCS authentication and person credential acceptance.

Signed-off-by: Jason C. Leach <jason.leach@fullboar.ca>
Signed-off-by: Jason C. Leach <jason.leach@fullboar.ca>
Signed-off-by: Jason C. Leach <jason.leach@fullboar.ca>
Copy link

sonarcloud bot commented Mar 28, 2024

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jleach jleach requested a review from cvarjao March 28, 2024 17:15
@jleach jleach enabled auto-merge (squash) March 28, 2024 17:25
Copy link
Contributor

@bryce-mcmath bryce-mcmath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. And this works when attestation is disabled from BCSC side?

@jleach jleach merged commit 8a71739 into main Mar 28, 2024
12 of 14 checks passed
@jleach jleach deleted the fix/attestation-workflow-2 branch March 28, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants