fix: bug switching to new verison of bc wallet #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
|
jleach
approved these changes
Apr 12, 2024
jleach
changed the title
jleach
reviewed
Apr 12, 2024
| tours, | ||
| onboarding, | ||
| dismissPersonCredentialOffer: personCredOfferDissmissed, | ||
| loginAttempt: {...initialState.loginAttempt, ...loginAttempt}, |
There was a problem hiding this comment.
Using {...} to copy an object in JavaScript is good for a basic copy and works in simple cases. But, it only copies the first layer deeply. If you have objects or arrays inside, they're still linked to the original, which may not be what you want for a complete deep copy. If you have nested objects or arrays you may want _.deepCopy() or something similar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the call in container-imp was using a shallow copy with the initial state, this meant that the new onboarding state wouldn't be copied and would result in postAuthScreens and didCompleteOnboarding to be undefined. I changed the functionality to have a deeper copy and that fixed the issue